Skip to content

Anders customizations #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2017
Merged

Anders customizations #1

merged 2 commits into from
Oct 10, 2017

Conversation

ehaivala
Copy link

  • Rename the package
  • Implement Sass loader for react-scripts webpack config

Refs ANDERS-275

@ehaivala ehaivala requested a review from suutari-ai October 10, 2017 10:22
@@ -176,20 +176,23 @@ module.exports = {
// In production, we use a plugin to extract that CSS to a file, but
// in development "style" loader enables hot editing of CSS.
{
test: /\.css$/,
test: /\.scss$/,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't drop the css. Also *.sass should be processed?

@ehaivala ehaivala force-pushed the anders_customizations branch 2 times, most recently from 5eb0bf9 to 79ddfc1 Compare October 10, 2017 10:35
@ehaivala ehaivala force-pushed the anders_customizations branch from 79ddfc1 to 3841fbd Compare October 10, 2017 10:36
Copy link
Member

@suutari-ai suutari-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@suutari-ai suutari-ai merged commit f62fd6e into master Oct 10, 2017
@suutari-ai suutari-ai deleted the anders_customizations branch October 10, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants